CLDSRV-616 [hf-7.70.51] Fix bucket policy check for anonymous requests#5750
Merged
bert-e merged 2 commits intohotfix/7.70.51from Feb 26, 2025
Merged
CLDSRV-616 [hf-7.70.51] Fix bucket policy check for anonymous requests#5750bert-e merged 2 commits intohotfix/7.70.51from
bert-e merged 2 commits intohotfix/7.70.51from
Conversation
When checking bucket policies and the following conditions
are true:
- The request is anonymous (`--no-sign-request`)
- There is a bucket policy with AWS principal
Then `_getAccountId` is called in arn === undefined and
causes an exception to be thrown.
The reason is that vault return the following authInfo
with anonymous requests:
{
arn: undefined,
canonicalID: 'http://acs.amazonaws.com/groups/global/AllUsers',
shortid: undefined,
email: undefined,
accountDisplayName: undefined,
IAMdisplayName: undefined
}
The fix is to check is to check is arn === undefined and fail
the check if the policy principal is not '*'
(cherry picked from commit d57e3a9)
Contributor
Hello dvasilas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I expected to find at least:
Please check the |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
fredmnl
approved these changes
Feb 26, 2025
anurag4DSB
approved these changes
Feb 26, 2025
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-616. Goodbye dvasilas. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #5748